Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INFRA: Modernize readthedocs configuration #6207

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

adswa
Copy link
Member

@adswa adswa commented Nov 17, 2021

This is an attempt to fix the readthedocs build failure. I've modernized our readthedocs.yml file into a modern version 2 one. The previous one was the culprit leading to the wrong requirements being installed - I hope this one may fix it.
I will kill all CIs in this PR.

@adswa
Copy link
Member Author

adswa commented Nov 17, 2021

The PR feature of readthedocs isn't enabled here, I fear we have to merge this to see if it works

Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, this hurts. Now I understand why me setting things in the UI had no impact. Stupid me. Thx, let's merge and see.

@mih mih added the semver-documentation Changes only affect the documentation, no impact on version label Nov 17, 2021
@mih mih merged commit ec1a324 into datalad:master Nov 17, 2021
@mih
Copy link
Member

mih commented Nov 17, 2021

@mih
Copy link
Member

mih commented Nov 17, 2021

Please push such changes straight into master, there is no value in working this out via a PR, IMHO

@adswa
Copy link
Member Author

adswa commented Nov 17, 2021

will do, thx

@adswa adswa deleted the infra-readthedocs branch November 17, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-documentation Changes only affect the documentation, no impact on version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants