Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move DownloadURL in the spirit of #3192 #6217

Merged
merged 1 commit into from
Nov 20, 2021
Merged

Conversation

mih
Copy link
Member

@mih mih commented Nov 19, 2021

Backward-compatibility shim is in place.

Follow-up to the failed #6178

Backward-compatibility shim is in place.
@mih mih added the semver-internal Changes only affect the internal API label Nov 19, 2021
@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #6217 (2bbd7d8) into master (13fc6ac) will decrease coverage by 1.71%.
The diff coverage is 94.11%.

❗ Current head 2bbd7d8 differs from pull request most recent head 2d051aa. Consider uploading reports for the commit 2d051aa to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6217      +/-   ##
==========================================
- Coverage   89.27%   87.56%   -1.72%     
==========================================
  Files         320      321       +1     
  Lines       41444    41720     +276     
==========================================
- Hits        37000    36531     -469     
- Misses       4444     5189     +745     
Impacted Files Coverage Δ
datalad/interface/__init__.py 100.00% <ø> (ø)
datalad/interface/download_url.py 0.00% <0.00%> (-97.96%) ⬇️
datalad/local/download_url.py 97.91% <97.91%> (ø)
datalad/local/tests/test_download_url.py 100.00% <100.00%> (ø)
datalad/version.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/wtf.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/addurls.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/interface/clean.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/no_annex.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/interface/unlock.py 0.00% <0.00%> (-100.00%) ⬇️
... and 105 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13fc6ac...2d051aa. Read the comment docs.

@mih mih merged commit e67fa02 into datalad:master Nov 20, 2021
@mih mih deleted the rf-downloadurl branch November 20, 2021 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-internal Changes only affect the internal API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant