Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move RunProcedure in the spirit of #3192 #6222

Merged
merged 3 commits into from
Nov 21, 2021
Merged

Conversation

mih
Copy link
Member

@mih mih commented Nov 21, 2021

Move RunProcedure in the spirit of #3192

Backward-compatibility shim is in place. Follow-up to the failed #6178

This also:

Backward-compatibility shim is in place.
A dataset on a FAT USB stick with a procedure could otherwise easily
cripple the procedure execution, because a simple Python .py script
without a shebang line will be executed as shell code.

Fixes datalad#6221
@mih mih changed the title Rf runprocedure Move RunProcedure in the spirit of #3192 Nov 21, 2021
@mih mih added the semver-minor Increment the minor version when merged label Nov 21, 2021
@codecov
Copy link

codecov bot commented Nov 21, 2021

Codecov Report

Merging #6222 (758466e) into master (acca2c0) will decrease coverage by 0.02%.
The diff coverage is 93.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6222      +/-   ##
==========================================
- Coverage   89.72%   89.70%   -0.03%     
==========================================
  Files         322      323       +1     
  Lines       41781    41900     +119     
==========================================
+ Hits        37489    37585      +96     
- Misses       4292     4315      +23     
Impacted Files Coverage Δ
datalad/interface/__init__.py 100.00% <ø> (ø)
datalad/local/run_procedure.py 92.50% <92.50%> (ø)
datalad/interface/run_procedure.py 100.00% <100.00%> (+6.50%) ⬆️
datalad/local/rerun.py 96.40% <100.00%> (ø)
datalad/local/tests/test_run_procedure.py 100.00% <100.00%> (ø)
datalad/cmd.py 85.95% <0.00%> (-4.75%) ⬇️
datalad/interface/common_cfg.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acca2c0...758466e. Read the comment docs.

@mih mih merged commit 0ceec65 into datalad:master Nov 21, 2021
@mih mih deleted the rf-runprocedure branch November 21, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run_procedure() broken on crippled FS
1 participant