Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make outcome of create-sibling-gin readily usable for a push data transfer #6230

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

mih
Copy link
Member

@mih mih commented Nov 22, 2021

This change corrects and overrules a premature conclusion by git-annex on the non-availability of an annex at the GIN platform -- which is merely an effect of happening prior any branch availability on GIN.

I decided to not pursue the alternative approach from #6204 (comment) which could potentially be more expensive with no clear advantage.

Fixes #6209

… transfer

This change corrects and overrules a premature conclusion by git-annex
on the non-availability of an annex at the GIN platform -- which is
merely an effect of happening prior any branch availability on GIN.

I decided to not pursue the alternative approach from

  datalad#6204 (comment)

which could potentially be more expensive with no clear advantage.

Fixes datalad#6209
@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

Merging #6230 (9299397) into master (5fcb235) will decrease coverage by 21.91%.
The diff coverage is 43.75%.

❗ Current head 9299397 differs from pull request most recent head 3ae5047. Consider uploading reports for the commit 3ae5047 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #6230       +/-   ##
===========================================
- Coverage   86.19%   64.27%   -21.92%     
===========================================
  Files         323      323               
  Lines       41849    41845        -4     
===========================================
- Hits        36072    26897     -9175     
- Misses       5777    14948     +9171     
Impacted Files Coverage Δ
...talad/distributed/tests/test_create_sibling_gin.py 75.00% <25.00%> (-25.00%) ⬇️
...ad/distributed/tests/test_create_sibling_ghlike.py 67.64% <33.33%> (-2.05%) ⬇️
datalad/distributed/create_sibling_gin.py 83.87% <55.55%> (-11.97%) ⬇️
datalad/version.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/wtf.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/addurls.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/interface/clean.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/interface/rerun.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/no_annex.py 0.00% <0.00%> (-100.00%) ⬇️
... and 157 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fcb235...3ae5047. Read the comment docs.

@mih mih added the semver-patch Increment the patch version when merged label Nov 22, 2021
@mih
Copy link
Member Author

mih commented Nov 23, 2021

Thx!

@mih mih merged commit 3bfdaab into datalad:master Nov 23, 2021
@mih mih deleted the bf-6209 branch November 23, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create-sibling-gin does not yield setup that is immediately usable by push
2 participants