Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BF: Properly pass result kwargs into result record of create-sibling-ria #6256

Merged
merged 1 commit into from
Nov 26, 2021
Merged

BF: Properly pass result kwargs into result record of create-sibling-ria #6256

merged 1 commit into from
Nov 26, 2021

Conversation

adswa
Copy link
Member

@adswa adswa commented Nov 26, 2021

The res_kwargs were accidentally placed into the format method
instead of get_status_dict, thus failing to deliver
common keys into the result record, ultimately leading
to omission of the result record in #6250.
This change should fix this, and close #6250

@adswa
BF: Properly pass result kwargs into result record
eaba5b8 
The res_kwargs were accidentally placed into the format method
instead of get_status_dict, thus failing to deliver
common keys into the result record, ultimately leading
to omission of the result record in datalad#6250.
This change should fix this, and close datalad#6250
@adswa adswa added the semver-patch Increment the patch version when merged label Nov 26, 2021
@adswa adswa mentioned this pull request Nov 26, 2021
Closed
mih
mih approved these changes Nov 26, 2021
View reviewed changes
Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the fix! I did not spot that in the original PR.

@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #6256 (6a4b43c) into master (a9f423a) will decrease coverage by 1.51%.
The diff coverage is 100.00%.

❗ Current head 6a4b43c differs from pull request most recent head eaba5b8. Consider uploading reports for the commit eaba5b8 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6256      +/-   ##
==========================================
- Coverage   89.62%   88.10%   -1.52%     
==========================================
  Files         323      323              
  Lines       41979    41966      -13     
==========================================
- Hits        37624    36976     -648     
- Misses       4355     4990     +635
Impacted Files Coverage Δ
datalad/distributed/create_sibling_gin.py 83.87% <ø> (ø)
datalad/distributed/create_sibling_gitea.py 60.52% <ø> (ø)
datalad/distributed/create_sibling_github.py 52.94% <ø> (ø)
datalad/distributed/create_sibling_gitlab.py 68.32% <ø> (ø)
datalad/distributed/create_sibling_gogs.py 100.00% <ø> (ø)
datalad/distributed/create_sibling_ria.py 81.86% <ø> (ø)
datalad/interface/base.py 89.66% <100.00%> (+0.14%) ⬆️
datalad/version.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/wtf.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/addurls.py 0.00% <0.00%> (-100.00%) ⬇️
... and 92 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9f423a...eaba5b8. Read the comment docs.

@mih mih merged commit 550118e into datalad:master Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mih mih mih approved these changes

Assignees
No one assigned
Labels
semver-patch Increment the patch version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create-sibling-ria does nothing
2 participants
@adswa @mih