Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discontinue use of and deprecate get_repo_instance() #6268

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

mih
Copy link
Member

@mih mih commented Dec 1, 2021

This is an old, now duplicate, implementation of getting a repo instance
from a path (that may point into a dataset, and not at its root). This
was only used in a few spots. I replaced it with the standard approach.

@mih mih added the semver-internal Changes only affect the internal API label Dec 1, 2021
@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #6268 (b37ad9c) into master (46120fe) will decrease coverage by 1.49%.
The diff coverage is 81.70%.

❗ Current head b37ad9c differs from pull request most recent head 8281569. Consider uploading reports for the commit 8281569 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6268      +/-   ##
==========================================
- Coverage   89.62%   88.13%   -1.50%     
==========================================
  Files         323      323              
  Lines       41984    41938      -46     
==========================================
- Hits        37629    36961     -668     
- Misses       4355     4977     +622     
Impacted Files Coverage Δ
datalad/core/distributed/tests/test_push.py 98.08% <ø> (-0.86%) ⬇️
datalad/core/local/run.py 97.78% <ø> (ø)
datalad/customremotes/ria_utils.py 95.23% <ø> (ø)
datalad/distributed/tests/test_ora_http.py 100.00% <ø> (ø)
datalad/distribution/tests/test_get.py 100.00% <ø> (ø)
datalad/local/tests/test_add_archive_content.py 99.24% <ø> (-0.39%) ⬇️
datalad/tests/test_utils.py 96.83% <ø> (+0.08%) ⬆️
datalad/distributed/ora_remote.py 31.33% <11.11%> (-0.14%) ⬇️
datalad/tests/test_config.py 99.70% <83.33%> (-0.30%) ⬇️
datalad/__init__.py 77.51% <87.50%> (-9.16%) ⬇️
... and 102 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46120fe...8281569. Read the comment docs.

This is an old, now duplicate, implementation of getting a repo instance
from a path (that may point into a dataset, and not at its root). This
was only used in a few spots. I replaced it with the standard approach.
@mih mih force-pushed the rf-repoinstance branch from 60966a2 to 8281569 Compare December 2, 2021 12:49
@mih mih merged commit 9bf24a5 into datalad:master Dec 2, 2021
@mih mih deleted the rf-repoinstance branch December 3, 2021 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-internal Changes only affect the internal API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant