Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: When calling uninstall without nocheck, strip hints for drops reckless parameter #6277

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

adswa
Copy link
Member

@adswa adswa commented Dec 2, 2021

Behavior if one were to use uninstall but forgot --nocheck:

datalad uninstall containers                       
uninstall(error): containers (dataset) [to-be-dropped dataset has revisions that are not available at any known sibling. Use `datalad push --to ...` to push these before dropping the local dataset, or ignore via `--reckless availability`. Unique revisions: ['master']]

Behavior now:

❱ datalad uninstall containers                                              2 !
uninstall(error): containers (dataset) [to-be-dropped dataset has revisions that are not available at any known sibling. Use `datalad push --to ...` to push these before dropping the local dataset, or ignore via `--nocheck`. Unique revisions: ['master']]

Fixes #6259

@adswa adswa added the semver-patch Increment the patch version when merged label Dec 2, 2021
@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #6277 (999db19) into master (b7ed22e) will decrease coverage by 54.24%.
The diff coverage is 55.71%.

❗ Current head 999db19 differs from pull request most recent head 7d84741. Consider uploading reports for the commit 7d84741 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #6277       +/-   ##
===========================================
- Coverage   89.62%   35.38%   -54.25%     
===========================================
  Files         323      323               
  Lines       41984    41966       -18     
===========================================
- Hits        37629    14848    -22781     
- Misses       4355    27118    +22763     
Impacted Files Coverage Δ
datalad/__main__.py 0.00% <ø> (-39.66%) ⬇️
datalad/api.py 65.95% <ø> (ø)
datalad/cmd.py 21.97% <ø> (-69.79%) ⬇️
datalad/cmdline/__init__.py 100.00% <ø> (ø)
datalad/cmdline/common_args.py 100.00% <ø> (ø)
datalad/cmdline/helpers.py 37.76% <ø> (-35.67%) ⬇️
datalad/cmdline/main.py 58.40% <ø> (-17.70%) ⬇️
datalad/cmdline/tests/__init__.py 0.00% <ø> (-100.00%) ⬇️
datalad/cmdline/tests/test_formatters.py 0.00% <ø> (-12.50%) ⬇️
datalad/cmdline/tests/test_helpers.py 0.00% <ø> (-100.00%) ⬇️
... and 574 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7ed22e...7d84741. Read the comment docs.

Copy link
Member

@bpoldrack bpoldrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright to me

@adswa
Copy link
Member Author

adswa commented Dec 3, 2021

The Appveyor failure is unrelated:

python -m coverage xml
C:\Python310\python.exe: No module named coverage
Command exited with code 1

@mih
Copy link
Member

mih commented Dec 3, 2021

Python 3.10? How come?

@adswa
Copy link
Member Author

adswa commented Dec 3, 2021

Python 3.10? How come?

Not sure, but rerunning the test worked:

python -m coverage xml
Wrote XML report to coverage.xml
curl -fsSL -o codecov.exe "https://uploader.codecov.io/latest/windows/codecov.exe"
.\codecov.exe -f "coverage.xml"
[2021-12-03T08:09:54.417Z] ['info'] 
     _____          _
    / ____|        | |
   | |     ___   __| | ___  ___ _____   __
   | |    / _ \ / _` |/ _ \/ __/ _ \ \ / /
   | |___| (_) | (_| |  __/ (_| (_) \ V /
    \_____\___/ \__,_|\___|\___\___/ \_/
  Codecov report uploader 0.1.13
[2021-12-03T08:09:54.447Z] ['info'] => Project root located at: C:/projects/datalad
[2021-12-03T08:09:54.449Z] ['info'] -> No token specified or token is empty
[2021-12-03T08:09:54.477Z] ['info'] Searching for coverage files...
[2021-12-03T08:09:54.525Z] ['info'] => Found 1 possible coverage files:
  __testhome__/coverage.xml
[2021-12-03T08:09:54.526Z] ['info'] Processing C:/projects/datalad/__testhome__/coverage.xml...
[2021-12-03T08:09:54.553Z] ['info'] Detected Appveyor CI as the CI provider.
[2021-12-03T08:09:54.555Z] ['info'] Pinging Codecov: https://codecov.io/upload/v4?package=uploader-0.1.13&token=*******&branch=master&build=jd40g6e7tyckp8a4&build_url=https%3A%2F%2Fci.appveyor.com%2Fproject%2Fdatalad%2Fdatalad%2Fbuilds%2F41756509%2Fjob%2Fjd40g6e7tyckp8a4&commit=b5b9e4a5a9b0a40d0f4a83e21012cf1ee53aa738&job=mih%2Fdatalad%2F1.0.7192&pr=6277&service=appveyor&slug=datalad%2Fdatalad&name=&tag=&flags=&parent=
[2021-12-03T08:09:55.490Z] ['info'] Uploading...
[2021-12-03T08:09:55.749Z] ['info'] {"status":"success","resultURL":"https://codecov.io/github/datalad/datalad/commit/7d84741666236953b0646c0895d018ff225991b5"}
powershell.exe while ((Test-Path "C:\Users\\appveyor\\Desktop\\BLOCK.txt")) { Start-Sleep 5 }
Build success

temporary glitch? no clue

Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thx!

@mih mih merged commit f91c7b7 into datalad:master Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uninstall gives hints from drop that don't apply to uninstall
3 participants