BF: RIARemote - set UI backend to annex to make it interactive #6287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpoldrack
force-pushed
the
bf-ria-remote-ui
branch
from
706c37c
to
a3dd633
Compare
Codecov Report
@@ Coverage Diff @@
## maint #6287 +/- ##
===========================================
- Coverage 90.19% 35.42% -54.78%
===========================================
Files 312 312
Lines 42272 42256 -16
===========================================
- Hits 38129 14970 -23159
- Misses 4143 27286 +23143
Continue to review full report at Codecov.
|
bpoldrack
force-pushed
the
bf-ria-remote-ui
branch
4 times, most recently
from
09ee39a
to
14d843f
Compare
Otherwise our UI would consider session non interactive and would not prompt for credentials etc. Closes datalad#5790
bpoldrack
force-pushed
the
bf-ria-remote-ui
branch
from
14d843f
to
14b2fc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise our UI would consider session non interactive and would not
prompt for credentials etc.
Closes #5790
This replaces #5825, as I could confirm (and understand) that this change is sufficient.
set_specialremoteas mentioned in #5825 (comment) seems to only be relevant for progressbars, which is of no concern for ORA ATM, since we simply report to annex.Rebased, and filed this PR from my fork, since I can't push to @yarikoptic's.