Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Update examples in create_sibling_gin #6289

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Conversation

mslw
Copy link
Contributor

@mslw mslw commented Dec 8, 2021

This is a small change. The example demonstrating how to create a sibling repo on GIN and register it as a common data source now suggests push as an additional step before configure to create git-annex branch remotely and obtain annex UUID. Otherwise, configuration would not happen properly. Addresses part of #6269

The example demonstrating how to create a sibling repo on GIN and
register it as a common data source now suggest push as an additional
step before configure to create git-annex branch remotely and obtain
annex UUID. Otherwise, configuration would not happen properly.
Addresses part of datalad#6269
@mslw mslw requested a review from bpoldrack December 8, 2021 15:08
@mslw mslw added the semver-documentation Changes only affect the documentation, no impact on version label Dec 8, 2021
@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #6289 (25c42c8) into master (43360ed) will decrease coverage by 37.68%.
The diff coverage is n/a.

❗ Current head 25c42c8 differs from pull request most recent head 4cba83e. Consider uploading reports for the commit 4cba83e to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #6289       +/-   ##
===========================================
- Coverage   89.79%   52.11%   -37.69%     
===========================================
  Files         329      329               
  Lines       42948    42928       -20     
===========================================
- Hits        38565    22371    -16194     
- Misses       4383    20557    +16174     
Impacted Files Coverage Δ
datalad/distributed/create_sibling_gin.py 74.19% <ø> (-9.68%) ⬇️
datalad/version.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/wtf.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/addurls.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/tests/test_api.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/tests/test_cmd.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/interface/clean.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/interface/rerun.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/no_annex.py 0.00% <0.00%> (-100.00%) ⬇️
... and 226 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43360ed...4cba83e. Read the comment docs.

Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Thx!

@mih mih merged commit c1a0261 into datalad:master Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-documentation Changes only affect the documentation, no impact on version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants