Skip to content

Fix invalid escape sequences#6293

Merged
mih merged 1 commit intodatalad:maintfrom
jwodder:fix-escapes
Dec 10, 2021
Merged

Fix invalid escape sequences#6293
mih merged 1 commit intodatalad:maintfrom
jwodder:fix-escapes

Conversation

@jwodder
Copy link
Copy Markdown
Contributor

@jwodder jwodder commented Dec 9, 2021

The code currently contains a number of invalid escape sequences (mostly escapes of special characters in regexes). These result in Python emitting DeprecationWarnings, and some future Python version will instead treat them as syntax errors. This PR fixes them.

@jwodder jwodder added the semver-patch Increment the patch version when merged label Dec 9, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 9, 2021

Codecov Report

Merging #6293 (77e1d17) into maint (4d554a0) will decrease coverage by 0.04%.
The diff coverage is 98.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##            maint    #6293      +/-   ##
==========================================
- Coverage   90.15%   90.11%   -0.05%     
==========================================
  Files         312      312              
  Lines       42272    42262      -10     
==========================================
- Hits        38111    38083      -28     
- Misses       4161     4179      +18     
Impacted Files Coverage Δ
datalad/tests/test_log.py 99.30% <87.50%> (ø)
datalad/customremotes/tests/test_archives.py 90.00% <92.30%> (+0.59%) ⬆️
datalad/cmdline/tests/test_main.py 83.79% <100.00%> (-1.04%) ⬇️
datalad/customremotes/tests/test_base.py 97.89% <100.00%> (ø)
datalad/customremotes/tests/test_datalad.py 97.87% <100.00%> (ø)
datalad/downloaders/tests/test_http.py 91.05% <100.00%> (+1.88%) ⬆️
datalad/downloaders/tests/test_providers.py 100.00% <100.00%> (ø)
...atalad/interface/tests/test_add_archive_content.py 99.62% <100.00%> (+<0.01%) ⬆️
datalad/metadata/tests/test_search.py 99.42% <100.00%> (ø)
datalad/support/tests/test_captured_exception.py 100.00% <100.00%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d554a0...77e1d17. Read the comment docs.

Copy link
Copy Markdown
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@mih mih merged commit bc5838d into datalad:maint Dec 10, 2021
@jwodder jwodder deleted the fix-escapes branch May 12, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-patch Increment the patch version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants