Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor enhancement to CONTRIBUTING.md #6309

Merged
merged 1 commit into from Dec 14, 2021

Conversation

bpoldrack
Copy link
Member

Simple addition serving as a release PR.

@bpoldrack bpoldrack added semver-documentation Changes only affect the documentation, no impact on version release Create a release when this pr is merged labels Dec 14, 2021
@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #6309 (911ada2) into maint (cf4526c) will decrease coverage by 3.18%.
The diff coverage is n/a.

❗ Current head 911ada2 differs from pull request most recent head f5c5ba8. Consider uploading reports for the commit f5c5ba8 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##            maint    #6309      +/-   ##
==========================================
- Coverage   90.15%   86.96%   -3.19%     
==========================================
  Files         312      312              
  Lines       42262    42262              
==========================================
- Hits        38100    36753    -1347     
- Misses       4162     5509    +1347     
Impacted Files Coverage Δ
datalad/version.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/wtf.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/addurls.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/no_annex.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/add_readme.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/check_dates.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/support/tests/utils.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/export_archive.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/export_to_figshare.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/metadata/extractors/tests/test_xmp.py 13.63% <0.00%> (-86.37%) ⬇️
... and 118 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf4526c...f5c5ba8. Read the comment docs.

Copy link
Member

@adswa adswa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition is helpful, thx. I don't know about the deletion, but if this variable doesn't exist anymore, great that its gone.

Copy link
Member

@adswa adswa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops meant to click approve not comment

@bpoldrack
Copy link
Member Author

I don't know about the deletion, but if this variable doesn't exist anymore, great that its gone.

Not deleted, just moved one down, so everything datalad.tests.*is in a block. ;-)

@bpoldrack bpoldrack merged commit bc3e36b into datalad:maint Dec 14, 2021
@yarikoptic yarikoptic removed the release Create a release when this pr is merged label Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-documentation Changes only affect the documentation, no impact on version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants