Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free GitRepo.bare of its ConfigManager-dependency #6323

Merged
merged 1 commit into from
Dec 17, 2021
Merged

Conversation

mih
Copy link
Member

@mih mih commented Dec 16, 2021

Fixes #6322

@mih mih added bare-mode Issue regarding operation on bare mode repositories semver-minor Increment the minor version when merged labels Dec 16, 2021
@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #6323 (3f20f93) into master (2b92a76) will decrease coverage by 30.54%.
The diff coverage is 100.00%.

❗ Current head 3f20f93 differs from pull request most recent head 1122d2e. Consider uploading reports for the commit 1122d2e to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #6323       +/-   ##
===========================================
- Coverage   89.87%   59.33%   -30.55%     
===========================================
  Files         331      331               
  Lines       43210    43186       -24     
===========================================
- Hits        38835    25623    -13212     
- Misses       4375    17563    +13188     
Impacted Files Coverage Δ
datalad/support/gitrepo.py 82.48% <100.00%> (-8.42%) ⬇️
datalad/version.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/wtf.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/addurls.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/interface/clean.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/interface/rerun.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/no_annex.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/interface/unlock.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/distribution/drop.py 0.00% <0.00%> (-100.00%) ⬇️
... and 208 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b92a76...1122d2e. Read the comment docs.

@mih
Copy link
Member Author

mih commented Dec 17, 2021

Will proceed.

@mih mih merged commit c610bee into datalad:master Dec 17, 2021
@mih mih deleted the barerer branch December 17, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bare-mode Issue regarding operation on bare mode repositories semver-minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitRepo.bare requires ConfigManager
1 participant