Install all data files under datalad/
#6336
Conversation
jwodder
added
semver-internal
Codecov Report
@@ Coverage Diff @@
## master #6336 +/- ##
==========================================
- Coverage 89.85% 81.12% -8.74%
==========================================
Files 331 331
Lines 43209 43189 -20
==========================================
- Hits 38827 35038 -3789
- Misses 4382 8151 +3769
Continue to review full report at Codecov.
|
| import sys | ||
| from os.path import dirname | ||
| from os.path import join as opj |
There was a problem hiding this comment.
isort does it . I guess we should separate "plain" imports from remapped (the "as" ones).
| findsome(opj('distribution', 'tests'), {'yaml'}) + | ||
| findsome(opj('metadata', 'tests', 'data'), {'mp3', 'jpg', 'pdf'}) | ||
| }, | ||
| include_package_data=True, |
There was a problem hiding this comment.
I wondered if we had it filtered on purpose. But probably not really on purpose. I guess it should be safe and we would not distribute something we do not actually like to distribute in the binary distribution.
datalad/test/ca/folder are currently not included when datalad is installed; this PR fixes that.datalad/metadata/tests/data/nifti1.nii.gzis currently not included when datalad is installed; this PR fixes that.package_dataspecification insetup.pylisted a number of file extensions to include underdatalad/resources/that are no longer present; this PR removes them.datalad/are included when installing datalad without needing to list all of the desired files' file extensions.