Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn just once about incomplete git config #6343

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Warn just once about incomplete git config #6343

merged 1 commit into from
Jan 13, 2022

Conversation

yarikoptic
Copy link
Member

Closes #6342

@yarikoptic yarikoptic added semver-patch Increment the patch version when merged UX user experience labels Jan 12, 2022
@codecov
Copy link

codecov bot commented Jan 12, 2022 •
edited
Loading

Codecov Report

Merging #6343 (bd9c6f0) into maint (de53497) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            maint    #6343      +/-   ##
==========================================
- Coverage   90.17%   90.15%   -0.02%     
==========================================
  Files         312      312              
  Lines       42269    42270       +1     
==========================================
- Hits        38115    38108       -7     
- Misses       4154     4162       +8
Impacted Files Coverage Δ
datalad/config.py 96.71% <100.00%> (+<0.01%) ⬆️
datalad/downloaders/tests/test_http.py 89.17% <0.00%> (-1.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de53497...bd9c6f0. Read the comment docs.

@yarikoptic yarikoptic requested a review from mih January 12, 2022 20:49
mih
mih approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@mih mih merged commit c37f31d into datalad:maint Jan 13, 2022
@yarikoptic yarikoptic deleted the bf-warn-once branch January 13, 2022 14:17
@adswa adswa mentioned this pull request Jan 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mih mih mih approved these changes

Assignees
No one assigned
Labels
semver-patch Increment the patch version when merged UX user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yarikoptic @mih