BF(TST): clean command should be invoked within a dataset #6359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Likely this test never failed to run (until it was ran during Debian package build) since was always invoked within git clone of datalad source code base. So "clean" was able to find the dataset to "work on". When building a package, there were no git repository and test failed since "clean" exited with 2 instead of 0.
|
Code Climate has analyzed commit 5f86ea2 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## master #6359 +/- ##
==========================================
- Coverage 89.84% 88.97% -0.88%
==========================================
Files 331 331
Lines 43208 43198 -10
==========================================
- Hits 38820 38434 -386
- Misses 4388 4764 +376
Continue to review full report at Codecov.
|
yarikoptic
added
the
semver-tests
|
trivial and only fixing a test, will merge (and drop patch from perspective debian package for upcoming 0.16.0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Likely this test never failed to run (until it was ran during
Debian package build) since was always invoked within git clone
of datalad source code base. So "clean" was able to find the dataset
to "work on". When building a package, there were no git repository
and test failed since "clean" exited with 2 instead of 0.