Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: condition access to isatty to have stream eval to True #6360

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

yarikoptic
Copy link
Member

A blind fix which feels like "the right thing to do" without
deep analysis. Closes #6357

A blind fix which feels like "the right thing to do" without
deep analysis.  Closes datalad#6357
@yarikoptic yarikoptic added the semver-patch Increment the patch version when merged label Jan 20, 2022
@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #6360 (b510465) into maint (e945d2f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            maint    #6360      +/-   ##
==========================================
+ Coverage   90.17%   90.18%   +0.01%     
==========================================
  Files         312      312              
  Lines       42270    42270              
==========================================
+ Hits        38116    38121       +5     
+ Misses       4154     4149       -5     
Impacted Files Coverage Δ
datalad/utils.py 84.99% <100.00%> (ø)
datalad/downloaders/base.py 78.32% <0.00%> (+0.34%) ⬆️
datalad/downloaders/tests/test_http.py 92.00% <0.00%> (+0.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e945d2f...b510465. Read the comment docs.

@yarikoptic
Copy link
Member Author

@datalad/developers please have a look at this mighty 1 liner patch -- I think it should not hurt

@adswa
Copy link
Member

adswa commented Jan 26, 2022

It likewise looks "like the right thing to do" to me, although I'm also looking at this blindly and haven't tested it out.

@mih
Copy link
Member

mih commented Jan 26, 2022

Pinky, blind eye, dead salmon be with me, we'll merge this.

@mih mih merged commit 92656ef into datalad:maint Jan 26, 2022
@yarikoptic yarikoptic deleted the bf-isatty branch April 5, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants