Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF(TST): add another condition to skip under http_proxy set #6361

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

yarikoptic
Copy link
Member

compare with http_proxy set:

root@smaug:/tmp/buildd/datalad-0.15.4+git528.g4ea21cb32# http_proxy=http://127.0.0.1:9/ PYTHONPATH=$PWD bin/datalad download-url http://example.com/bogus
It is highly recommended to configure Git before using DataLad. Set both 'user.name' and 'user.email' configuration variables.
[INFO   ] Downloading 'http://example.com/bogus' into '/tmp/buildd/datalad-0.15.4+git528.g4ea21cb32/'
download_url(error): /tmp/buildd/datalad-0.15.4+git528.g4ea21cb32/ (file) [AccessFailedError(Failed to establish a new session 1 times. )]

to without (when we should do that assert):

root@smaug:/tmp/buildd/datalad-0.15.4+git528.g4ea21cb32# PYTHONPATH=$PWD bin/datalad download-url http://example.com/bogus
It is highly recommended to configure Git before using DataLad. Set both 'user.name' and 'user.email' configuration variables.
[INFO   ] Downloading 'http://example.com/bogus' into '/tmp/buildd/datalad-0.15.4+git528.g4ea21cb32/'
download_url(error): /tmp/buildd/datalad-0.15.4+git528.g4ea21cb32/ (file) [DownloadError(Access to http://example.com/bogus has failed: not found)]

dependencies:

- dependencies: cmd:git=2.34.1 cmd:annex=8.20211123 cmd:bundled-git=UNKNOWN cmd:system-git=2.34.1 cmd:system-ssh=8.7p1 cmd:7z=16.02 annexremote=1.6.0 platformdirs=2.4.1 exifread=2.3.2 humanize=0.0.0 iso8601=0.1.16 keyring=23.5.0 keyrings.alt=UNKNOWN msgpack=1.0.2 mutagen=1.45.1 requests=2.25.1

root@smaug:/tmp/buildd/datalad-0.15.4+git528.g4ea21cb32# python3 --version
Python 3.9.10

Didn't investigate if applicable to maint so will add label just in case

compare with http_proxy set:

    root@smaug:/tmp/buildd/datalad-0.15.4+git528.g4ea21cb32# http_proxy=http://127.0.0.1:9/ PYTHONPATH=$PWD bin/datalad download-url http://example.com/bogus
    It is highly recommended to configure Git before using DataLad. Set both 'user.name' and 'user.email' configuration variables.
    [INFO   ] Downloading 'http://example.com/bogus' into '/tmp/buildd/datalad-0.15.4+git528.g4ea21cb32/'
    download_url(error): /tmp/buildd/datalad-0.15.4+git528.g4ea21cb32/ (file) [AccessFailedError(Failed to establish a new session 1 times. )]

to without (when we should do that assert):

    root@smaug:/tmp/buildd/datalad-0.15.4+git528.g4ea21cb32# PYTHONPATH=$PWD bin/datalad download-url http://example.com/bogus
    It is highly recommended to configure Git before using DataLad. Set both 'user.name' and 'user.email' configuration variables.
    [INFO   ] Downloading 'http://example.com/bogus' into '/tmp/buildd/datalad-0.15.4+git528.g4ea21cb32/'
    download_url(error): /tmp/buildd/datalad-0.15.4+git528.g4ea21cb32/ (file) [DownloadError(Access to http://example.com/bogus has failed: not found)]

dependencies:

	- dependencies: cmd:git=2.34.1 cmd:annex=8.20211123 cmd:bundled-git=UNKNOWN cmd:system-git=2.34.1 cmd:system-ssh=8.7p1 cmd:7z=16.02 annexremote=1.6.0 platformdirs=2.4.1 exifread=2.3.2 humanize=0.0.0 iso8601=0.1.16 keyring=23.5.0 keyrings.alt=UNKNOWN msgpack=1.0.2 mutagen=1.45.1 requests=2.25.1

	root@smaug:/tmp/buildd/datalad-0.15.4+git528.g4ea21cb32# python3 --version
	Python 3.9.10
@yarikoptic yarikoptic added cherry-pick-to-maint semver-patch Increment the patch version when merged labels Jan 21, 2022
@codeclimate
Copy link

codeclimate bot commented Jan 21, 2022

Code Climate has analyzed commit 84b4b0c and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #6361 (84b4b0c) into master (c666b36) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6361   +/-   ##
=======================================
  Coverage   89.84%   89.85%           
=======================================
  Files         331      331           
  Lines       43196    43196           
=======================================
+ Hits        38810    38814    +4     
+ Misses       4386     4382    -4     
Impacted Files Coverage Δ
datalad/local/tests/test_download_url.py 100.00% <ø> (ø)
datalad/utils.py 85.25% <0.00%> (+0.08%) ⬆️
datalad/distributed/tests/test_ria_basics.py 97.91% <0.00%> (+0.29%) ⬆️
datalad/distributed/ora_remote.py 31.78% <0.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c666b36...84b4b0c. Read the comment docs.

@yarikoptic
Copy link
Member Author

ok, this is very trivial and description outlines the unavoidable necessity IMHO. If any objections would come up, we can always revert this trivial patch

@yarikoptic yarikoptic merged commit 09700ae into datalad:master Jan 25, 2022
@yarikoptic
Copy link
Member Author

CPed to maint and pushed directly as 0.15.5-1-g6e96447d1, removing the label

@yarikoptic yarikoptic deleted the bf-tst-proxy branch April 5, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant