BF: python 3.10 compatibility fixes #6363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking at https://docs.python.org/3/library/unittest.mock.html#patch-object it should be autospec and not auto_spec. So, in effect, this kwarg seems was simply ignored before. Thus the easiest fix is to remove it.
…tting Before py 3.10 it was "optional arguments:", and now became just "options:".
|
hm, appveyor looks like stalled on ubuntu and mac restarted incomplete |
Codecov Report
@@ Coverage Diff @@
## maint #6363 +/- ##
=======================================
Coverage 90.17% 90.17%
=======================================
Files 312 312
Lines 42270 42271 +1
=======================================
+ Hits 38116 38117 +1
Misses 4154 4154
Continue to review full report at Codecov.
|
|
ok, upon restart of appveyor -- all green. since neither of stalled tests relate to changes in this PR -- I consider them not a show stopper here. Please review/merge or I will do in a day. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the failing tests in #6362 and add 3.10 testing for travis (more radical CI changes to be added to
masterafter this PR gets merged intomaintand then intomaster)