Drop python 3.6 support, remove some no longer needed kludges, merge of maint #6364
Conversation
yarikoptic: CPed from datalad#6317 since why not?
Looking at https://docs.python.org/3/library/unittest.mock.html#patch-object it should be autospec and not auto_spec. So, in effect, this kwarg seems was simply ignored before. Thus the easiest fix is to remove it.
…tting Before py 3.10 it was "optional arguments:", and now became just "options:".
* enh-py3.10: ENH(TST,CI): add (limited) run on travis for python 3.10 BF: adjust our ugly tuneup of argparse output for its change in formatting BF(TST,py3.10): remove auto_spec=True BF: When download-url gets Pathobject as path convert it to a string Conflicts: datalad/interface/download_url.py -- was already str()ed in master as well
|
Code Climate has analyzed commit 1edd67e and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
@mih, from top of your head -- what should we do about redness of codeclimate in the example of this PR? |
|
Nothing. I am still trying to explore the possibilities. The messages so far are reasonable, but not applicable. Ignore and proceed, I would say |
|
The Mac tests timed out with |
eh, searched through our issues but it seems there were no prior timing out for this one. eh, restarted incomplete on appveyour -- let's see if resurfaces... if doesn't show up, I will proceed with merge. (I've merged satellite PR in |
Codecov Report
@@ Coverage Diff @@
## master #6364 +/- ##
==========================================
+ Coverage 89.84% 89.89% +0.04%
==========================================
Files 331 331
Lines 43196 43214 +18
==========================================
+ Hits 38810 38847 +37
+ Misses 4386 4367 -19
Continue to review full report at Codecov.
|
|
marked two errors from codeclimate as no fix (md5 and loading a pickle). All green now. To not miss some new python 3.10 gotchas to get introduced to |
|
This PR has brought the appveyor job names out if sync with their config. Moreover, there are now two runs on ubuntu with py3.8 (which is the default version). I will trim this and resync the names. |
oh, didn't spot that |
Sits on top of the merge of #6363 into master.