Skip to content

Allow multiple threads in ProducerConsumer with python <= 3.7#6371

Merged
yarikoptic merged 1 commit intodatalad:masterfrom
christian-monch:enh-parallel
Jan 26, 2022
Merged

Allow multiple threads in ProducerConsumer with python <= 3.7#6371
yarikoptic merged 1 commit intodatalad:masterfrom
christian-monch:enh-parallel

Conversation

@christian-monch
Copy link
Contributor

The new runner implementation allows for threads in ProducerConsumer in python versions <= 3.7 because we
do not use asyncio any longer in the runner

The new runner implementation allows for threads in
ProducerConsumer in python versions < 3.8 because we
do not use asyncio any longer in WitlessRunner
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 01dec66 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Security 1

View more on Code Climate.

@christian-monch christian-monch added the semver-internal Changes only affect the internal API label Jan 25, 2022
@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #6371 (01dec66) into master (c666b36) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6371      +/-   ##
==========================================
- Coverage   89.84%   89.82%   -0.02%     
==========================================
  Files         331      331              
  Lines       43196    43230      +34     
==========================================
+ Hits        38810    38833      +23     
- Misses       4386     4397      +11     
Impacted Files Coverage Δ
datalad/support/parallel.py 90.55% <ø> (-4.84%) ⬇️
datalad/support/tests/test_parallel.py 94.85% <ø> (-0.08%) ⬇️
datalad/local/tests/test_download_url.py 98.13% <0.00%> (-1.87%) ⬇️
datalad/utils.py 85.25% <0.00%> (+0.08%) ⬆️
datalad/distributed/tests/test_ria_basics.py 97.91% <0.00%> (+0.29%) ⬆️
datalad/distributed/ora_remote.py 31.78% <0.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c666b36...01dec66. Read the comment docs.

@christian-monch christian-monch changed the title WIP: allow multiple threads in ProducerConsumer with python <= 3.7 Allow multiple threads in ProducerConsumer with python <= 3.7 Jan 25, 2022
@christian-monch
Copy link
Contributor Author

christian-monch commented Jan 25, 2022

We are about to have 3.7 as minimal supported version in master

It makes sense then for the 3.7 versions. And it removes code that is no longer needed from 3.8 onwards

@yarikoptic
Copy link
Member

Thank you @christian-monch !
looks good to me and I guess could even go against maint (I would have liked it since I kept running into this warning for quite a while and it annoyed me, but I upgraded at least one of the hosts since then). I am ok either way. To not wait for it and since CI is happy, will merge as is for now but will add a label for potential CP to maint.

@yarikoptic yarikoptic merged commit 63f0237 into datalad:master Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-to-maint semver-internal Changes only affect the internal API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants