Major CLI refactoring#6378
Merged
Merged
Conversation
e8db678 to
089daa8
Compare
d1fc89a to
6c018d8
Compare
Codecov Report
@@ Coverage Diff @@
## master #6378 +/- ##
==========================================
- Coverage 89.84% 89.46% -0.39%
==========================================
Files 331 342 +11
Lines 43155 42822 -333
==========================================
- Hits 38773 38309 -464
- Misses 4382 4513 +131
Continue to review full report at Codecov.
|
|
Code Climate has analyzed commit dcb8704 and detected 77 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Member
Author
|
Ok, no objections were voiced. Some additional fixes will be coming in via #6391 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to replace the previous CLI with a consolidated code base. Detailed history of the changes since c666b36 is available at https://github.com/datalad/datalad-cli
Initial benchmark estimates:
No major slowdown, despite simplified implementations in some places.
Global help generation sped up, by avoiding to parse extensions twice.
TODO:
datalad.clifromdatalad.cli.testsalonedatalad.interface.basedeprecatedextension still uses deprecatedfrom datalad.cmdline.helpers import get_repo_instance, which is removed here (maybe needs to come back, was only deprecated with 0.16)datalad.cmdlineimportsChangelog
💫 Enhancements and new features
🪓 Deprecations and removals
datalad.cmdlinewas (re)moved, onlydatalad.cmdline.helpers.get_repo_instanceis kept for a deprecation period (by @mih)📝 Documentation
datalad.interface.baseare now included in the documentation (by @mih)🏠 Internal
datalad.climodule #6383 (by @mih)🛡 Tests
datalad.cli.testshave an improved module coverage of 80% (by @mih)