Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make room for dedicated CLI benchmarks + cleanup #6381

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Conversation

mih
Copy link
Member

@mih mih commented Jan 27, 2022

This is only to establish a set of benchmarks to be able to evaluate a follow-up PR with a major CLI refactoring.

CI, apart from the benchmarks, will be canceled.

@mih mih added the team-core core API/commands (https://github.com/datalad/datalad/issues/6365) label Jan 27, 2022
@codeclimate
Copy link

codeclimate bot commented Jan 27, 2022

Code Climate has analyzed commit 5afb768 and detected 18 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2
Security 16

View more on Code Climate.

@mih mih added performance Improve performance of an existing feature semver-tests Changes only affect tests, no impact on version labels Jan 27, 2022
@mih
Copy link
Member Author

mih commented Jan 27, 2022

Thx @yarikoptic for the review. I am running out of time, so I decided to ignore the benchmakrs but focus on the CLI instead. I hope this is OK, otherwise we can also approach the CLI merge without expanded benchmarks.

@mih mih merged commit 01793cc into datalad:master Jan 27, 2022
@mih mih deleted the clibench branch January 27, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Improve performance of an existing feature semver-tests Changes only affect tests, no impact on version team-core core API/commands (https://github.com/datalad/datalad/issues/6365)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants