Skip to content

Remove unused helpers from datalad.interface.utils #6392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2022

Conversation

mih
Copy link
Member

@mih mih commented Feb 1, 2022

See #6005

Changelog

🪓 Deprecations and removals

  • Remove unused and untested datalad.interface.utils helpers cls2cmdlinename and path_is_under

mih added 2 commits February 1, 2022 09:38
This used to be an internal helper as very long time ago.
No longer used after the remove() rewrite. Not used anywhere else, incl.
extensions.
@mih mih added team-core core API/commands (https://github.com/datalad/datalad/issues/6365) CHANGELOG-missing When a PR's description does not contain a changelog item, yet. labels Feb 1, 2022
@codeclimate
Copy link

codeclimate bot commented Feb 1, 2022

Code Climate has analyzed commit e3e77de and detected 0 issues on this pull request.

View more on Code Climate.

@mih mih added the semver-minor Increment the minor version when merged label Feb 1, 2022
@codecov
Copy link

codecov bot commented Feb 1, 2022

Codecov Report

Merging #6392 (e3e77de) into master (c2183b3) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6392      +/-   ##
==========================================
+ Coverage   89.94%   89.97%   +0.03%     
==========================================
  Files         344      344              
  Lines       43286    43273      -13     
==========================================
+ Hits        38934    38937       +3     
+ Misses       4352     4336      -16     
Impacted Files Coverage Δ
datalad/interface/utils.py 96.22% <ø> (+5.38%) ⬆️
datalad/cli/common_args.py 100.00% <0.00%> (ø)
datalad/interface/common_opts.py 100.00% <0.00%> (ø)
datalad/interface/base.py 90.25% <0.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2183b3...e3e77de. Read the comment docs.

@mih mih removed the CHANGELOG-missing When a PR's description does not contain a changelog item, yet. label Feb 1, 2022
@mih mih merged commit 3bdc08c into datalad:master Feb 1, 2022
@mih mih deleted the rf-unused2 branch February 1, 2022 18:39
@adswa adswa mentioned this pull request Nov 14, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor Increment the minor version when merged team-core core API/commands (https://github.com/datalad/datalad/issues/6365)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant