Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce code duplication and add documentation #6398

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Conversation

mih
Copy link
Member

@mih mih commented Feb 1, 2022

Changelog

馃彔 Internal

  • Reduce code duplication in datalad.support.json_py

@mih mih added the semver-internal Changes only affect the internal API label Feb 1, 2022
@codeclimate
Copy link

codeclimate bot commented Feb 1, 2022

Code Climate has analyzed commit 093fb81 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #6398 (093fb81) into master (9309842) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6398      +/-   ##
==========================================
+ Coverage   89.85%   89.98%   +0.13%     
==========================================
  Files         344      344              
  Lines       43291    43274      -17     
==========================================
+ Hits        38900    38942      +42     
+ Misses       4391     4332      -59     
Impacted Files Coverage 螖
datalad/support/json_py.py 98.86% <100.00%> (酶)
datalad/support/gitrepo.py 90.37% <0.00%> (+0.16%) 猬嗭笍
datalad/distribution/tests/test_install.py 100.00% <0.00%> (+0.20%) 猬嗭笍
datalad/tests/utils.py 89.39% <0.00%> (+0.21%) 猬嗭笍
datalad/distribution/tests/test_dataset.py 99.70% <0.00%> (+0.29%) 猬嗭笍
datalad/utils.py 85.25% <0.00%> (+0.53%) 猬嗭笍
datalad/tests/test_tests_utils.py 98.91% <0.00%> (+0.54%) 猬嗭笍
datalad/tests/test_utils.py 97.61% <0.00%> (+0.56%) 猬嗭笍
datalad/tests/test_log.py 99.30% <0.00%> (+0.69%) 猬嗭笍
datalad/distribution/tests/test_update.py 99.82% <0.00%> (+0.69%) 猬嗭笍
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 9309842...093fb81. Read the comment docs.

@mih mih merged commit 606cb83 into datalad:master Feb 2, 2022
@mih mih deleted the rf-json branch February 2, 2022 06:26
@mih mih added the team-core core API/commands (https://github.com/datalad/datalad/issues/6365) label Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-internal Changes only affect the internal API team-core core API/commands (https://github.com/datalad/datalad/issues/6365)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant