Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent double-rendering of save results by run. #6421

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Conversation

mih
Copy link
Member

@mih mih commented Feb 6, 2022

This should have been done from the very beginning, but it was not
necessary to achieve the desired behavior due to a series of
side-effects of the complexity of determining the effective result
renderer (see #6394 for an entry point into the series of changes).

Changelog

🐛 Bug Fixes

This should have been done from the very beginning, but it was not
necessary to achieve the desired behavior due to a series of
side-effects of the complexity of determining the effective result
renderer (see datalad#6394 for an entry point into the series of changes).

Fixes datalad#6420
@codeclimate
Copy link

codeclimate bot commented Feb 6, 2022

Code Climate has analyzed commit 3633c50 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Feb 6, 2022

Codecov Report

Merging #6421 (3633c50) into master (ba846a9) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6421      +/-   ##
==========================================
- Coverage   89.91%   89.88%   -0.03%     
==========================================
  Files         345      345              
  Lines       43282    43652     +370     
==========================================
+ Hits        38917    39237     +320     
- Misses       4365     4415      +50     
Impacted Files Coverage Δ
datalad/core/local/run.py 97.80% <ø> (ø)
datalad/local/add_archive_content.py 65.81% <0.00%> (-22.22%) ⬇️
datalad/distribution/tests/test_get.py 100.00% <0.00%> (ø)
datalad/tests/test_config.py 99.71% <0.00%> (+0.01%) ⬆️
datalad/support/annexrepo.py 91.58% <0.00%> (+0.08%) ⬆️
datalad/support/tests/test_annexrepo.py 97.97% <0.00%> (+0.13%) ⬆️
datalad/core/distributed/tests/test_push.py 98.93% <0.00%> (+0.21%) ⬆️
datalad/distribution/tests/test_create_sibling.py 77.42% <0.00%> (+0.22%) ⬆️
datalad/log.py 88.04% <0.00%> (+0.39%) ⬆️
datalad/local/addurls.py 94.96% <0.00%> (+0.45%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba846a9...3633c50. Read the comment docs.

@mih mih added semver-patch Increment the patch version when merged team-core core API/commands (https://github.com/datalad/datalad/issues/6365) labels Feb 6, 2022
@mih
Copy link
Member Author

mih commented Feb 6, 2022

Installation of asv fails and brings down all benchmark and travis runs. Unrelated to this change.

@mih
Copy link
Member Author

mih commented Feb 8, 2022

Ok, let's go with this simple fix

@mih mih merged commit d7acd09 into datalad:master Feb 8, 2022
@mih mih deleted the bf-6420 branch February 8, 2022 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Increment the patch version when merged team-core core API/commands (https://github.com/datalad/datalad/issues/6365)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run: all result records rendered twice
1 participant