Remove an unnecessary warning from the runner #6425
Conversation
|
Thanks for the fix! Just tried it out 👍 |
Your welcome :-) |
Codecov Report
@@ Coverage Diff @@
## master #6425 +/- ##
==========================================
+ Coverage 89.57% 90.01% +0.44%
==========================================
Files 345 348 +3
Lines 43032 44149 +1117
==========================================
+ Hits 38545 39741 +1196
+ Misses 4487 4408 -79
Continue to review full report at Codecov.
|
|
Is the |
| kwargs = { | ||
| **self.popen_kwargs, | ||
| **dict( | ||
| bufsize=0, | ||
| stdin=subprocess.PIPE if self.write_stdin else self.stdin, | ||
| stdout=subprocess.PIPE if self.catch_stdout else None, | ||
| stderr=subprocess.PIPE if self.catch_stderr else None, | ||
| shell=True if isinstance(self.cmd, str) else False | ||
| shell=True if isinstance(self.cmd, str) else False # nosec |
There was a problem hiding this comment.
What nosec - what understand it, code climate?
There was a problem hiding this comment.
It is understood by bandit, a security linter that is used by codeclimate.
It is used by |
christian-monch
force-pushed
the
bf-remove-unnecessary-runner-warning
branch
from
d331bb7 to
d76ddbd
Compare
|
Code Climate has analyzed commit d76ddbd and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Remove an unnecessary warning from the runner in the case where
stdinis provided, but does not fit any of our specially handled cases.Fixes #6395
Changelog
🐛 Bug Fixes