-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPT+RF: create-sibling --since=^ -- diff to HEAD, use "^" instead of "" #6436
Conversation
Primary motivation is very slow --since= mode of operation of create-sibling on a heavy superdataset (see datalad#6399). Although it could be argued that there might be a benefit from create-sibling to be able to create siblings for not yet committed submodules, I think such use cases are sparse if any and thus diff"ing to the committed state (HEAD) is actually the desired effect. Fixes datalad#6399 (although I did not check explicitly)
to be consistent with "push" and thus reduce cognitive load. Old value of an empty string will remain supported. While at it, added a tiny bit of testing to ensure that --since actually works out the way we expect and only deals with that subdataset (or notneeded)
Code Climate has analyzed commit fe60cd4 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## master #6436 +/- ##
==========================================
+ Coverage 89.87% 89.95% +0.08%
==========================================
Files 348 348
Lines 43764 43772 +8
==========================================
+ Hits 39331 39377 +46
+ Misses 4433 4395 -38
Continue to review full report at Codecov.
|
It is magically green! Even nearly all benchmarks under 1 - can't be bad ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not let this unicorn event slip!
note FTR: damn, burnt myself -- thought that it was against |
Two commits:
Moreover, apparently
--since=
was not even documented before, this fixes it.First commit I would not even mind to destine against
maint
but decided not to bother since 0.16.0 is imminent, right?Changelog
💫 Enhancements and new features
create-sibling --since=^
mode will now be as fast aspush --since=^
to figure out for which subdatasets to create siblings.🪓 Deprecations and removals
create-sibling
will require now "^" instead of an empty string forsince
option.📝 Documentation
--since=^
mode of operation ofcreate-sibling
is documented now