BF/RF: Silence save result rendering in clone and download url #6446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
action summaries There is no need to evaluate whether the result renderer choice for the command class is correct in a loop - once at the start of eval_func() should suffice This reinstates result summaries for a few commands, among probably others download-url, save, and clone
Previously, a download-url would double-report: datalad download-url -O chinstrap_05.jpg https://unsplash.com/photos/8PxCm4HsPX8/download?force=true [INFO ] Downloading 'https://unsplash.com/photos/8PxCm4HsPX8/download?force=true' into '/tmp/ab/chinstrap_05.jpg' download_url(ok): /tmp/ab/chinstrap_05.jpg (file) add(ok): chinstrap_05.jpg (file) add(ok): chinstrap_05.jpg (file) save(ok): . (dataset) save(ok): . (dataset) action summary: add (ok: 1) save (ok: 1) action summary: add (ok: 1) download_url (ok: 1) save (ok: 1) Now, the result rendering of save is disabled: datalad download-url -O chinstrap_03.jpg https://unsplash.com/photos/8PxCm4HsPX8/download?force=true [INFO ] Downloading 'https://unsplash.com/photos/8PxCm4HsPX8/download?force=true' into '/tmp/ab/chinstrap_03.jpg' download_url(ok): /tmp/ab/chinstrap_03.jpg (file) add(ok): chinstrap_03.jpg (file) save(ok): . (dataset) action summary: add (ok: 1) download_url (ok: 1) save (ok: 1)
Previously, clone would overreport save results: datalad clone -d . https://gin.g-node.org/adswa/bids-data input install(ok): input (dataset) add(ok): input (file) add(ok): input (file) add(ok): .gitmodules (file) add(ok): .gitmodules (file) save(ok): . (dataset) save(ok): . (dataset) add(ok): .gitmodules (file) save(ok): . (dataset) add(ok): .gitmodules (file) save(ok): . (dataset) Now, the doubled add and save results are removed: datalad clone -d . https://gin.g-node.org/adswa/bids-data input14 install(ok): input14 (dataset) add(ok): input14 (file) add(ok): .gitmodules (file) save(ok): . (dataset) add(ok): .gitmodules (file) save(ok): . (dataset) Still, there is a duplicate .gitmodules save operation that I can't silence
Previously, an install yielded to identical results: ❱ datalad install input15 install(ok): /tmp/ab/input15 (dataset) [Installed subdataset in order to get /tmp/ab/input15] install(ok): /tmp/ab/input15 (dataset) [Installed subdataset in order to get /tmp/ab/input15] Now, it only reports one: ❱ datalad install input15 install(ok): /tmp/ab/input15 (dataset) [Installed subdataset in order to get /tmp/ab/input15]
|
Code Climate has analyzed commit 4e3a5b1 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## master #6446 +/- ##
=======================================
Coverage 89.97% 89.97%
=======================================
Files 348 348
Lines 43859 43859
=======================================
Hits 39464 39464
Misses 4395 4395
Continue to review full report at Codecov.
|
mih
approved these changes
Feb 14, 2022
This was referenced Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change has introduced double reporting for a number of commands (#6445). I haven't figured out why this change has suddenly happened, but this PR silences (
result_renderer='disabled') internal calls tosaveandgetthat should be silenced anyway.In addition, it contains a small RF that centralizes general result renderer switches outside of a loop. Coincidentally, this RF reinstates action summaries for a few commands that had lost it (#6258)
Changelog
🐛 Bug Fixes