BF: No object tree in RIA w/o special remote#6495
Merged
mih merged 1 commit intodatalad:masterfrom Feb 25, 2022
Merged
Conversation
bpoldrack
added
semver-patch
mih
reviewed
Feb 24, 2022
`create-sibling-ria` and the underlying helper created a dataset's `annex/objects` directory unconditionally. However, only having the git repositories in store with no special remote and no data whatsoever is valid and supported usecase. The existence of that (empty) directory increases the inode count per dataset, is superfluous and leads to failures of annex commands being executed directly in store. While the latter is something to generally be very careful about, there are valid usecases and with the previous behavior we'd cause annex to pointlessly fail on discovery of that dir, indicating to annex that the repo is not annex-init'ed but was apparently used with annex before.
bpoldrack
force-pushed
the
bf-ria-no-sr
branch
from
c9dec43 to
b332555
Compare
|
Code Climate has analyzed commit b332555 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Member
|
I restarted the failing travis test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create-sibling-riaand the underlying helper created a dataset'sannex/objectsdirectory unconditionally.However, only having the git repositories in store with no special remote and no data whatsoever is valid and supported usecase. The existence of that (empty) directory increases the inode count per dataset, is superfluous and leads to failures of annex commands being executed directly in store. While the latter is something to generally be very careful about, there are valid usecases and with the previous behavior we'd cause annex to pointlessly fail on discovery of that dir, indicating to annex that the repo is not annex-init'ed but was apparently used with annex before.
Changelog
🐛 Bug Fixes
create-sibling-riano longer creates anannex/objectsdirectory in-store, when called with--no-storage-sibling. #6495 (by @bpoldrack )