Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard RI-type determination #6500

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Guard RI-type determination #6500

merged 1 commit into from
Feb 25, 2022

Conversation

mih
Copy link
Member

@mih mih commented Feb 24, 2022

Instead of randomly crashing, raise a uniform ValueError whenever
anything goes wrong. Include any original exception as a cause.

Re #6494 this changes:

[ERROR  ] ValueError(invalid literal for int() with base 10: 'datalad-datasets') (ValueError)

to

[ERROR  ] ValueError(Could not determine resource identifier type for 'https://github.com:datalad-datasets/human-connectome-project-openaccess.git') (ValueError)

Changelog

馃悰 Bug Fixes

Instead of randomly crashing, raise a uniform ValueError whenever
anything goes wrong. Include any original exception as a cause.

Re datalad#6494 this changes:

```
[ERROR  ] ValueError(invalid literal for int() with base 10: 'datalad-datasets') (ValueError)
```

to

```
[ERROR  ] ValueError(Could not determine resource identifier type for 'https://github.com:datalad-datasets/human-connectome-project-openaccess.git') (ValueError)
```

Fixes datalad#6494
@mih mih added semver-patch Increment the patch version when merged team-core core API/commands (https://github.com/datalad/datalad/issues/6365) labels Feb 24, 2022
@codeclimate
Copy link

codeclimate bot commented Feb 24, 2022

Code Climate has analyzed commit 1d5307a and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Security 2

View more on Code Climate.

@mih
Copy link
Member Author

mih commented Feb 24, 2022

Failure pattern is #6492

@mih mih merged commit 4befd2d into datalad:master Feb 25, 2022
@mih mih deleted the bf6494 branch February 25, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Increment the patch version when merged team-core core API/commands (https://github.com/datalad/datalad/issues/6365)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_guess_ri_cls(ri) must be guarded
1 participant