require_dataset() uniformly raises NoDatasetFound #6521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before it claimed to raise InsufficientArgumentsError uniformly, but actually raised NoDatasetFound or ValueError, depending on the exact error condition. This change consolidates and documents raising NoDatasetFound, which seems to make most sense. Coincidentally, this also fixes datalad#6503
|
Code Climate has analyzed commit feb4ac3 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
Metalad's |
bpoldrack
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before it claimed to raise InsufficientArgumentsError uniformly,
but actually raised NoDatasetFound or ValueError, depending
on the exact error condition.
This change consolidates and documents raising NoDatasetFound,
which seems to make most sense.
Changelog
🐛 Bug Fixes
require_dataset()now uniformly raisesNoDatasetFoundwhen no dataset was found. Implementations that catch the previously documentedInsufficientArgumentsErroror the actually raisedValueErrorwill continue to work, becauseNoDatasetFoundis derived from both types. Fixes datalad-configuration dump not working without dataset #6503