Prevent internal download functionality from logging at INFO level #6564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See datalad#6545 for the rational. datalad#6545 was filed as compound issue, hence cannot be solved here. Logging is maintained, but at DEBUG level. This enables using the downloader functionality when the download is a technical detail (fetch remote state info) rather then the primary goal (as with data downloads) -- without unconditionally polluting user-facing output with traced of internal processing. It is unclear for which functionality the INFO level message would be or was possibly essential, but any such functionality should either use progress logging, or result reporting nowadays.
mih
added
corpse-in-basement
team-core
|
Code Climate has analyzed commit 4cff107 and detected 0 issues on this pull request. View more on Code Climate. |
bpoldrack
approved these changes
Mar 17, 2022
|
Failure pattern is #6492 |
|
ohhh thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #6545 for the rational. #6545 was unfortunately filed as compound issue, hence
cannot be solved here.
Logging is maintained, but at DEBUG level. This enables using the
downloader functionality when the download is a technical detail (fetch
remote state info) rather then the primary goal (as with data downloads)
-- without unconditionally polluting user-facing output with traced of
internal processing.
It is unclear for which functionality the INFO level message would be or
was possibly essential, but any such functionality should either use
progress logging, or result reporting nowadays.
This remove a line like:
from every attempt to enable a
ria+httpspecial remote.Changelog
🪓 Deprecations and removals
BaseDownloader.fetch()is logging download attempts on DEBUG (previously INFO) level to avoid polluting output of higher-level commands. See Downloaders not suitable for internal usage #6545