Don't use download_url in ORA #6609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separating reading provider configs from downloading a key, since this was a per-key operation unneccessarily slowing down HTTP downloads. This also enables per-key progress bars when downloading over HTTP.
|
Code Climate has analyzed commit 2d748a7 and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
bpoldrack
added
semver-patch
Codecov Report
@@ Coverage Diff @@
## master datalad/datalad#6609 +/- ##
==========================================
+ Coverage 91.14% 91.15% +0.01%
==========================================
Files 350 353 +3
Lines 44232 44552 +320
==========================================
+ Hits 40316 40613 +297
- Misses 3916 3939 +23
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separating reading provider configs from downloading a key, since this
was a per-key operation unnecessarily slowing down HTTP downloads.
Magically, this also enables per-key progress bars (addressing datalad/datalad-ria#13 for the HTTP case). This seems to depend on the persistence of the
Providerand/orDownloaderinstance across keys. Same call path does not work, whenProvidersare read anew from the configs on a per-key basis (as the implementation usingdownload_urldid).Changelog
🐛 Bug Fixes
💫 Enhancements and new features