Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Fix wrong key name of annex' JSON records #6624

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

bpoldrack
Copy link
Member

Annex uses a - instead of _ in its JSON key names.
This correction should only have a minor impact on behavior. Instead of
the intended replacement of a list of messages under error-messages
with a joined message under error_message, the created record
unintentionally had both.

Fixes #6621

Changelog

馃彔 Internal

  • Fix misspelled use of a key name in annex' JSON records.

Annex uses a `-` instead of `_` in its JSON key names.
This correction should only have a minor impact on behavior. Instead of
the intended replacement of a list of messages under `error-messages`
with a joined message under `error_message`, the created record
unintentionally had both.

(Closes datalad#6621)
@bpoldrack bpoldrack added the semver-internal Changes only affect the internal API label Apr 11, 2022
@mslw
Copy link
Contributor

mslw commented Apr 11, 2022

It definitely addresses the issue - code looks less ambiguous now. As we discussed in another thread, keeping error-messages is not bad per se, but they probably wouldn't be used elsewhere and keeping just error_message eliminates the need for second guessing.

I see two test runs fail on mac, but on a cursory glance I don't think they're related (also the failure seems very selective).

@bpoldrack
Copy link
Member Author

Thx, @mslw. Yes, those failures are the known issue with the snapshot (annex version that that test cannot properly match) and #6599

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-internal Changes only affect the internal API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants