BF: Fix wrong key name of annex' JSON records#6624
Merged
bpoldrack merged 1 commit intodatalad:maintfrom Apr 12, 2022
Merged
Conversation
Annex uses a `-` instead of `_` in its JSON key names. This correction should only have a minor impact on behavior. Instead of the intended replacement of a list of messages under `error-messages` with a joined message under `error_message`, the created record unintentionally had both. (Closes datalad#6621)
Contributor
|
It definitely addresses the issue - code looks less ambiguous now. As we discussed in another thread, keeping I see two test runs fail on mac, but on a cursory glance I don't think they're related (also the failure seems very selective). |
mslw
approved these changes
Apr 11, 2022
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Annex uses a
-instead of_in its JSON key names.This correction should only have a minor impact on behavior. Instead of
the intended replacement of a list of messages under
error-messageswith a joined message under
error_message, the created recordunintentionally had both.
Fixes #6621
Changelog
🏠 Internal