Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Require importlib-metadata >=3.6 for Python < 3.10 for entry_points taking kwargs #6631

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

effigies
Copy link
Contributor

Datalad now depends on entry_points taking kwargs, introduced in python/importlib_metadata@8320ade, first released in importlib-metadata 3.6.

Apologies for ignoring your PR template, but it's unclear where this fits in your changelog set.

@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #6631 (26e1671) into master (c659a98) will increase coverage by 0.00%.
The diff coverage is 96.19%.

❗ Current head 26e1671 differs from pull request most recent head 4090fbb. Consider uploading reports for the commit 4090fbb to get more accurate results

@@           Coverage Diff           @@
##           master    #6631   +/-   ##
=======================================
  Coverage   91.16%   91.16%           
=======================================
  Files         353      353           
  Lines       44438    44484   +46     
=======================================
+ Hits        40513    40556   +43     
- Misses       3925     3928    +3     
Impacted Files Coverage Δ
datalad/distribution/create_sibling.py 65.42% <ø> (ø)
datalad/support/sshconnector.py 87.19% <ø> (ø)
datalad/distribution/tests/test_create_sibling.py 77.80% <88.88%> (ø)
datalad/support/tests/test_annexrepo.py 97.87% <93.33%> (-0.05%) ⬇️
datalad/support/annexrepo.py 91.41% <96.87%> (+0.22%) ⬆️
datalad/support/gitrepo.py 90.81% <97.50%> (-0.16%) ⬇️
datalad/core/local/tests/test_save.py 97.97% <100.00%> (ø)
datalad/distributed/drop.py 97.22% <100.00%> (ø)
datalad/tests/test_version.py 80.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aff4a2...4090fbb. Read the comment docs.

@yarikoptic yarikoptic changed the title MNT: Require importlib-metadata >=3.6 for Python < 3.10 MNT: Require importlib-metadata >=3.6 for Python < 3.10 for entry_points taking kwargs Apr 19, 2022
@yarikoptic yarikoptic added the semver-patch Increment the patch version when merged label Apr 19, 2022
@yarikoptic
Copy link
Member

THANK YOU @effigies . Would you be so kind to rebase it against maint? It should be included in the patch release.

Datalad now depends on entry_points taking kwargs, introduced in python/importlib_metadata@8320ade, first released in importlib-metadata 3.6.
@codeclimate
Copy link

codeclimate bot commented Apr 19, 2022

Code Climate has analyzed commit 4090fbb and detected 0 issues on this pull request.

View more on Code Climate.

@effigies
Copy link
Contributor Author

THANK YOU @effigies . Would you be so kind to rebase it against maint? It should be included in the patch release.

Should have read the CONTRIBUTORS... I feel like there needs to be a tl;dr for those things.

@effigies effigies changed the base branch from master to maint April 19, 2022 15:05
@yarikoptic
Copy link
Member

Just contribute more often and it will be in your fingertips ;)

@effigies
Copy link
Contributor Author

I can't see an obvious connection between this patch and the test failures.

@yarikoptic
Copy link
Member

yeah, that mac snapshot (likely) test failure is known... we just thought to wait for a new release of annex but might just need to tune up our skips. Let's proceed. We might kick out maint release in upcoming days.

@yarikoptic yarikoptic merged commit 59beec6 into datalad:maint Apr 19, 2022
@effigies effigies deleted the patch-1 branch April 19, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants