-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove two too prominent create() INFO log message that duplicate DEBUG log and harmonize some other log messages #6638
Conversation
Every invocation produces this INFO-level message: ``` % datalad create myds [INFO ] Creating a new annex repo at /tmp/myds create(ok): /tmp/myds (dataset) ``` This is not a long-running operation. In most cases, the INFO log and the result arrive near-simultaneously. It also duplicates DEBUG messages: ``` [INFO ] Creating a new annex repo at /tmp/demo12 [DEBUG ] Initialize empty Git repository at '/tmp/demo12' [DEBUG ] Initializing annex repository at /tmp/demo12... ``` Removed for a cleaner user experience. Fixes datalad#6633
Since majority use that form to signal beginning of some action. Also renamed one Initating into Initializing, and removed "Attempt" since all of them are
Codecov Report
@@ Coverage Diff @@
## maint #6638 +/- ##
==========================================
- Coverage 91.17% 90.67% -0.50%
==========================================
Files 353 353
Lines 44496 44494 -2
==========================================
- Hits 40568 40344 -224
- Misses 3928 4150 +222
Continue to review full report at Codecov.
|
ok with me. I wonder if while at it we should also harmonize that DEBUG message to also use -ing form instead of imperative form: Looking at instances
it seems we have that form mostly, and use also |
Thx @yarikoptic I would have used a dedicated PR for that, but I am fine with the change. |
Since now we are both involved in this PR, I guess best would be if some other @datalad/developers hits Merge or expresses the opinion on this tiny PR ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The failures are all unrelated.
🚀 PR was released in |
Every invocation produces this INFO-level message:
This is not a long-running operation. In most cases, the INFO log and the result arrive near-simultaneously.
It also duplicates DEBUG messages:
Removed for a cleaner user experience.
Fixes #6633
Changelog
Not needed.