Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Don't use deprecated AnnexRepo.add_urls #6683

Merged
merged 1 commit into from
May 6, 2022

Conversation

bpoldrack
Copy link
Member

This method was deprecated. Don't use it in tests, that are not
specifically testing this method.

Follow up to #6667

Changelog

馃洝 Tests

  • Remove usage of deprecated AnnexRepo.add_urls in tests

@bpoldrack bpoldrack added the semver-tests Changes only affect tests, no impact on version label May 5, 2022
This method was deprecated. Don't use it in tests, that are not
specifically testing this method.
@codeclimate
Copy link

codeclimate bot commented May 6, 2022

Code Climate has analyzed commit 7c06f28 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #6683 (7c06f28) into master (89475e7) will increase coverage by 55.78%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master    #6683       +/-   ##
===========================================
+ Coverage   34.63%   90.42%   +55.78%     
===========================================
  Files         353      353               
  Lines       45655    45673       +18     
===========================================
+ Hits        15814    41299    +25485     
+ Misses      29841     4374    -25467     
Impacted Files Coverage 螖
datalad/customremotes/tests/test_datalad.py 97.61% <100.00%> (+97.61%) 猬嗭笍
datalad/local/tests/test_add_archive_content.py 99.62% <100.00%> (+99.62%) 猬嗭笍
datalad/support/tests/test_annexrepo.py 97.87% <100.00%> (+97.87%) 猬嗭笍
datalad/core/local/tests/test_create.py 98.39% <0.00%> (+0.40%) 猬嗭笍
datalad/core/local/create.py 99.29% <0.00%> (+0.70%) 猬嗭笍
datalad/interface/base.py 91.28% <0.00%> (+1.02%) 猬嗭笍
datalad/core/local/save.py 98.91% <0.00%> (+1.08%) 猬嗭笍
datalad/_version.py 47.70% <0.00%> (+1.27%) 猬嗭笍
datalad/dataset/gitrepo.py 96.75% <0.00%> (+1.38%) 猬嗭笍
datalad/core/distributed/push.py 92.54% <0.00%> (+1.56%) 猬嗭笍
... and 285 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 89475e7...7c06f28. Read the comment docs.

@yarikoptic yarikoptic merged commit 4585b28 into datalad:master May 6, 2022
@mih mih mentioned this pull request Jul 1, 2022
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-tests Changes only affect tests, no impact on version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants