-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discontinue usage of testrepos #6690
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6690 +/- ##
==========================================
+ Coverage 88.82% 90.43% +1.60%
==========================================
Files 353 353
Lines 45733 45802 +69
==========================================
+ Hits 40622 41419 +797
+ Misses 5111 4383 -728
Continue to review full report at Codecov.
|
891956e
to
78e96dc
Compare
FTR: AppVeyor Failure is on win "no module named coverage". I consider this unrelated and it's after the actual test runs which are fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed a few inconsistent relative imports - is that intentional?
datalad/tests/test_tests_utils.py
Outdated
@with_testrepos(flavors=['network']) | ||
def magical(): | ||
raise AssertionError("Must not be ran") | ||
assert_raises(SkipTest, magical) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yarikoptic would have appreciated to have this tested as long as we have debian packages built for extensions which still use @with_testrepos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my POV the only extension using it is deprecated
, which would also be the place to migrate this functionality to. @yarikoptic are you aware of other extensions using it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found none other. To be kosher should have gone through deprecation cycle for removal but since only for testing, indeed might be worth replacing with a stub right away requiring datalad-deprecated
to be installed to use it. This PR doesn't need to be contingent on that
This commit removes the only remaining use of the decorator 'with_testrepos' from 'test_annexrepo.py'
Code Climate has analyzed commit ada1778 and detected 0 issues on this pull request. View more on Code Climate. |
This has been hanging here for too long, hence I made an attempt to unstuck it be addressing the previous comments: absolute imports, keeping the If the tests pass, this closes #6144 from my POV. |
I believe my comments were addressed, I have no objections, thank you @bpoldrack - let's proceed and the rest (full deprecation) could be in a follow up PR if so desired |
Thank you! |
Closes #6144
Changelog
🛡 Tests