Add annex.private to ephemeral clones. That would make git-annex not assign shared (in git-annex branch) annex uuid. #6702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## maint #6702 +/- ##
=======================================
Coverage 91.18% 91.18%
=======================================
Files 353 353
Lines 44515 44523 +8
=======================================
+ Hits 40591 40599 +8
Misses 3924 3924
Continue to review full report at Codecov.
|
Set annex.private=true when cloning with --reckless=ephemeral. This is better than declaring 'dead here', since it not only prevents availability from 'here' to be propagated, but also the location (uuid) itself. Otherwise workflows based on ephemeral clones would accumulate lots of locations that are essentially gone by the time another repo learns about their existence. However, still declare dead regardless. Seamingly superfluous in combination with private mode, but a safeguard: Should an older annex happen to touch the repo, at least the availability is still not propagated. Closes datalad#5835
|
something nagging me about use case where I would want to know but can't come up with it... hence -- sounds great! @bpoldrack -- please rebase on maint -- I have mitigated the |
|
I rebased to current |
|
The docfailure is fixed in I restarted the failed Appveyor build to see if its a fluke. In any case, it seems unrelated to the changes proposed in this PR. |
|
Even though it brings a behavioral change, I would not mind having it merged. |
yarikoptic
changed the title
|
🚀 PR was released in |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set annex.private=true when cloning with --reckless=ephemeral. This is
better than declaring 'dead here', since it not only prevents
availability from 'here' to be propagated, but also the location (uuid)
itself. Otherwise workflows based on ephemeral clones would accumulate
lots of locations that are essentially gone by the time another repo
learns about their existence.
However, still declare dead regardless. Seamingly superfluous in
combination with private mode, but a safeguard: Should an older annex
happen to touch the repo, at least the availability is still not
propagated.
Closes #5835
Changelog
💫 Enhancements and new features
datalad clone --reckless=ephemeralnow uses git-annex' private repositories