Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Catch KeyErrors from unavailable WTF infos #6712

Merged
merged 2 commits into from
May 31, 2022
Merged

Conversation

adswa
Copy link
Member

@adswa adswa commented May 30, 2022

When unavailble WTF sections are requested, e.g., '-S dataset'
outside of any dataset, the command errors with a KeyError
(#6711). This change catches this and reports an impossible
result for the affected section, such that the problem is
communicated orderly, and that the reporting of other sections
is not impacted

PS: Is maint the correct target for this?

Changelog

馃悰 Bug Fixes

When unavailble WTF sections are requested, e.g., '-S dataset'
outside of any dataset, the command errors with a KeyError
(datalad#6711). This change catches this and reports an impossible
result for the affected section, such that the problem is
communicated orderly, and that the reporting of other sections
is not impacted
@adswa adswa added the semver-patch Increment the patch version when merged label May 30, 2022
@adswa adswa linked an issue May 30, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #6712 (2d092ce) into maint (476b48d) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

鉂 Current head 2d092ce differs from pull request most recent head 1ae76b3. Consider uploading reports for the commit 1ae76b3 to get more accurate results

@@            Coverage Diff             @@
##            maint    #6712      +/-   ##
==========================================
- Coverage   91.18%   91.18%   -0.01%     
==========================================
  Files         353      353              
  Lines       44515    44518       +3     
==========================================
+ Hits        40591    40592       +1     
- Misses       3924     3926       +2     
Impacted Files Coverage 螖
datalad/local/wtf.py 83.39% <50.00%> (-0.54%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 476b48d...1ae76b3. Read the comment docs.

Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PS: Is maint the correct target for this?

oh yes. Greedy me just wants a unittest for the goodness of UX ;) should be trivial to craft, so I do not see a reason why to skip

@yarikoptic
Copy link
Member

LGTM -- thank you @adswa !

@yarikoptic yarikoptic merged commit 446d3c0 into datalad:maint May 31, 2022
yarikoptic added a commit to yarikoptic/datalad that referenced this pull request May 31, 2022
* commit '0.16.3-13-g446d3c0bd':
  TST: Add minimal testcase for datalad#6712
  BF: Catch KeyErrors from unavailable WTF infos
  BF(TST): do full clone to ensure having most recent tag
  Add annex.private to ephemeral clones
  Replace Zenodo DOI with JOSS for due credit
  ENH: comment out errorneous check
  ENH: convert-git-annex-layout - better condensed feedback via tqdm
  A little helper to jump between git annex objects layouts
  ENH: provide argcomplete version depend at least 1.12.3
  [skip ci] Update RST changelog
  Update CHANGELOG.md [skip ci]
  No change for a PR to trigger release
  TST: test correct content availability of url-key files after url-sanitization
  BF: Sanitize keys before marking content availability
  MNT: Move _sanitize_key helper from ora_remote into annex_utils

 Conflicts:
	datalad/support/tests/test_fileinfo.py - was already CPed into maint, caused conflict on import. fixed
@adswa adswa deleted the bf-wtf branch May 31, 2022 17:53
@github-actions
Copy link

github-actions bot commented Jun 2, 2022

馃殌 PR was released in 0.16.4 馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released semver-patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wtf crashed with -S dataset executed with no dataset
2 participants