Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Remove unused helper for listing sorted files #6722

Merged
merged 1 commit into from
May 31, 2022

Conversation

adswa
Copy link
Member

@adswa adswa commented May 31, 2022

There are no uses of this function in core (as the comment indicated) or in any of the extensions (as determined by a quick git grep - but tests will tell if I have missed anything).
Removing it to not drag it further along with us.

closes #6432

There are no uses of this function in core or in any of the extensions.
Removing it to not drag it further along with us
@adswa adswa added the semver-internal Changes only affect the internal API label May 31, 2022
@codeclimate
Copy link

codeclimate bot commented May 31, 2022

Code Climate has analyzed commit 7261a61 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #6722 (7261a61) into master (d75b8c0) will increase coverage by 2.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6722      +/-   ##
==========================================
+ Coverage   88.16%   90.17%   +2.01%     
==========================================
  Files         353      353              
  Lines       45722    45735      +13     
==========================================
+ Hits        40311    41243     +932     
+ Misses       5411     4492     -919     
Impacted Files Coverage Δ
datalad/utils.py 85.33% <ø> (+3.14%) ⬆️
datalad/runner/protocol.py 84.05% <0.00%> (-13.05%) ⬇️
datalad/cmd.py 83.07% <0.00%> (-10.98%) ⬇️
datalad/log.py 81.96% <0.00%> (-5.89%) ⬇️
datalad/runner/coreprotocols.py 94.73% <0.00%> (-5.27%) ⬇️
datalad/support/keyring_.py 90.47% <0.00%> (-4.77%) ⬇️
datalad/runner/runnerthreads.py 94.06% <0.00%> (-3.39%) ⬇️
datalad/support/collections.py 81.25% <0.00%> (-3.13%) ⬇️
datalad/tests/test_base.py 97.22% <0.00%> (-2.78%) ⬇️
datalad/customremotes/datalad.py 61.64% <0.00%> (-2.74%) ⬇️
... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d75b8c0...7261a61. Read the comment docs.

@yarikoptic
Copy link
Member

FTR, seems was used in check_page2annex_same_incoming_and_public of a crawler tests, but I don't think that one even migrated to datalad-crawler extension in those extraction times... it seems indeed should be safe to kill. Thanks @adswa !

@yarikoptic yarikoptic merged commit d657c17 into datalad:master May 31, 2022
@mih mih mentioned this pull request Jul 1, 2022
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-internal Changes only affect the internal API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datalad.utils.sorted_files() unused, untested
2 participants