Remove unused and untested log filter helpers#6747
Merged
yarikoptic merged 1 commit intodatalad:masterfrom Jun 6, 2022
Merged
Conversation
NoProgressLog and OnlyProgressLog. They seem to be left-overs from a ProgressHandler-related implementation that is no longer useful. There is no trace of this trivial code being used in any extention. Fixes datalad#6732
|
Code Climate has analyzed commit 85e02d8 and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
adswa
reviewed
Jun 4, 2022
| pb.clear() | ||
|
|
||
|
|
||
| class NoProgressLog(logging.Filter): |
Member
There was a problem hiding this comment.
There only is a comment referring to it in l. 235 of this file ((filtered away by NoProgressLog)), maybe it should be removed, too, to avoid future confusion?
Codecov Report
@@ Coverage Diff @@
## master #6747 +/- ##
==========================================
+ Coverage 88.79% 90.41% +1.62%
==========================================
Files 353 353
Lines 45744 45755 +11
==========================================
+ Hits 40617 41370 +753
+ Misses 5127 4385 -742
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
🪓 Deprecations and removals
NoProgressLogandOnlyProgressLog. Fixes Log filtersdatalad.log.(Only|No)ProgressLogare unused and untested #6732