ENH: LogProgressBar to gain "start" reporting#6756
Merged
Conversation
Spotted while comparing behavior of log_progress whenever it does not log progress at all it logs initiation of specific actions while we were reporting only at the end of the operation. This way we would be reporting also the beginning: $> rm -rf datalad && DATALAD_UI_PROGRESSBAR=log datalad clone https://github.com/datalad/datalad.git [INFO ] Start Clone attempt [INFO ] Start Enumerating [INFO ] Enumerating done in 0.000520706 sec [INFO ] Start Counting [INFO ] Counting 174 Objects done in 0.0136135 sec at 12781 Objects/sec [INFO ] Start Compressing [INFO ] Compressing 93 Objects done in 0.033551 sec at 2772 Objects/sec [INFO ] Start Receiving [INFO ] Receiving 96987 Objects done in 6 seconds at 14219 Objects/sec [INFO ] Start Resolving [INFO ] Resolving 75566 Deltas done in 0.604427 sec at 125021 Deltas/sec [INFO ] Clone attempt 2 Candidate locations done in 8 seconds at 0.246755 Candidate locations/sec install(ok): /tmp/datalad (dataset) This is just an idea, and depends on either LogProgressBar not to be completely removed (see datalad#4325 (comment))
|
Code Climate has analyzed commit 945d8ff and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## master #6756 +/- ##
==========================================
+ Coverage 88.82% 90.41% +1.59%
==========================================
Files 353 353
Lines 45741 45745 +4
==========================================
+ Hits 40631 41362 +731
+ Misses 5110 4383 -727
Continue to review full report at Codecov.
|
Member
|
I don't have formed an opinion re removal. However, it's a minimal change and doesn't make removal more complicated, hence don't see a reason to object. |
Member
Author
|
well, since not even enabled by default and no objections -- let's proceed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotted while comparing behavior of log_progress whenever it does
not log progress at all it logs initiation of specific actions while
we were reporting only at the end of the operation. This way we would be reporting
also the beginning:
This is just an idea, and depends on either LogProgressBar not to be
completely removed (see #4325 (comment))
💫 Enhancements and new features