Prevent duplicated result rendering when searching in default datasets #6765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit disables the result renderer in a recursively called 'ds.search()' because the result will be rendered by the caller.
Codecov Report
@@ Coverage Diff @@
## maint #6765 +/- ##
==========================================
- Coverage 91.17% 90.14% -1.04%
==========================================
Files 354 354
Lines 44612 44691 +79
==========================================
- Hits 40677 40286 -391
- Misses 3935 4405 +470
Continue to review full report at Codecov.
|
yarikoptic
changed the title
|
Thank you @christian-monch ! I will release with this. |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Fixes #6763
This commit disables the result renderer in a recursive call to
Dataset.search(). This recursive call is used when no dataset to search through is found and the default super-dataset, i.e.///is used.When the result renderer in the recursive call was not disabled, each result was reported twice.
Changelog
🐛 Bug Fixes