Fix "common data source" test to use a valid URL (maint-based & extended edition) #6788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the test relied on git-annex to be more tolerant to invalid repository URLs than Git itself. Fixes datalad#6779
Would have failed with older git-annex without having URL corrected
since otherwise we can run into indigestion by git-annex such as datalad.runner.exception.CommandError: CommandError: 'git -c diff.ignoreSubmodules=none annex initremote fresh-sr type=git location=http://127.0.0.1:38045/.git autoenable=true -c annex.dotfiles=true' failed with exitcode 1 under /home/yoh/.tmp/datalad_temp_test_as_common_datasource49kq5qqu [out: 'initremote fresh-sr failed'] [err: 'git-annex: found multiple git remotes with specified location initremote: 1 failed']
since otherwise git-annex would just change URL and have a single remote thus just forgetting the original one
yarikoptic
added
semver-patch
|
fails unrelated |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased #6785 against
maintand then extended the test to actually test that we can get data from that remote for which we specified the now fixed URL. While at it, as described in #6785 (comment) I have ran into another peculiarity of git-annex which would have made #6785 fail on some versions of git-annex, and thus made that remote be served from another URL. Now seems all to work with both bleeding edge and not so versions.. It is "fun" -- most recent version works it out fine - just replaces one URL with another since UUID is the same (thus makes sense):With that, again, we would not be testing those both cases ('configured' vs 'added' with url), so evolved test to do have two different repos (UUIDs) with two urls and test explicitly that we can get from any of them (so they are autoenabled etc)