Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid import of nose-based tests.utils, make skip_if_no_module() and skip_if_no_network() allowed at module level #6817

Merged
merged 2 commits into from
Jul 8, 2022

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jul 8, 2022

This PR addresses the test failures seen in the conda-forge feedstock:

  • A remaining import of nose-based datalad.test.utils is updated so that nose is no longer needed during tests.
  • Calling skip_if_no_module() and skip_if_no_network() at module level (as is done in datalad/downloaders/tests/test_s3.py) is now allowed.

I suggest releasing this in 0.17.1 soon so that a passing release can be made on conda-forge.

Changelog

🛡 Tests

  • Fix failing tests on conda-forge

@jwodder jwodder added the semver-tests Changes only affect tests, no impact on version label Jul 8, 2022
@jwodder jwodder changed the title Fix tests Fix failing tests on conda-forge Jul 8, 2022
@yarikoptic yarikoptic changed the title Fix failing tests on conda-forge Avoid import of nose-based tests.utils, make skip_if_no_module() and skip_if_no_network() allowed at module level Jul 8, 2022
@yarikoptic
Copy link
Member

yarikoptic commented Jul 8, 2022

I suggest releasing this in 0.17.1 soon so that a passing release can be made on conda-forge.

in general I would not oppose it but since diff is trivial and tests related, might be better to just take this diff as a patch for now. Meanwhile, adjusted the PR title to provide more details which would be taken into Changelog.

edit: I meanwhile will look into updating debian packaging, more gotchas might arise from it...

edit2: pushed as a patch in regro-cf-autotick-bot/datalad-feedstock@065e555

@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #6817 (0224e27) into maint (2dea515) will increase coverage by 0.95%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            maint    #6817      +/-   ##
==========================================
+ Coverage   90.25%   91.20%   +0.95%     
==========================================
  Files         354      354              
  Lines       46057    46057              
==========================================
+ Hits        41567    42007     +440     
+ Misses       4490     4050     -440     
Impacted Files Coverage Δ
datalad/runner/tests/test_threadsafety.py 100.00% <100.00%> (ø)
datalad/tests/utils_pytest.py 89.72% <100.00%> (ø)
datalad/tests/utils.py 66.76% <0.00%> (+9.55%) ⬆️
datalad/tests/test_tests_utils.py 92.34% <0.00%> (+92.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dea515...0224e27. Read the comment docs.

@yarikoptic
Copy link
Member

travis fail is the ssh copy one, known... unrelated. Let's proceed. thank you @jwodder . more fixes will pile up and then we will release. I think I accounted for all in conda feestock but may be there would be more

@yarikoptic yarikoptic merged commit 8465a03 into datalad:maint Jul 8, 2022
@github-actions
Copy link

🚀 PR was released in 0.17.1 🚀

@jwodder jwodder deleted the fix-tests branch May 12, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released semver-tests Changes only affect tests, no impact on version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants