Skip to content

RM(TST): remove testing of datalad.test which was removed from 0.17.0#6822

Merged
yarikoptic merged 1 commit into
datalad:maintfrom
yarikoptic:rm-test-test
Jul 9, 2022
Merged

RM(TST): remove testing of datalad.test which was removed from 0.17.0#6822
yarikoptic merged 1 commit into
datalad:maintfrom
yarikoptic:rm-test-test

Conversation

@yarikoptic

Copy link
Copy Markdown
Member

This test was always skipped since conditioned on having numpy installed
and we no longer keep it as a dependency of any kind so on all CIs it was
skipped. But I ran into it while testing for debian build where for
some reason numpy was installed

Actually detected while looking at fails for conda: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=533304&view=logs&j=517fe804-fa30-5dc2-1413-330699242c05&t=c10fa5f2-fdf6-5338-3bdb-c4bea7c23412

This test was always skipped since conditioned on having numpy installed
and we no longer keep it as a dependency of any kind so on all CIs it was
skipped.  But I ran into it while testing for debian build where for
some reason numpy was installed
@yarikoptic yarikoptic added the semver-tests Changes only affect tests, no impact on version label Jul 8, 2022
@codecov

codecov Bot commented Jul 9, 2022

Copy link
Copy Markdown

Codecov Report

Merging #6822 (6e56d75) into maint (2dea515) will increase coverage by 0.90%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            maint    #6822      +/-   ##
==========================================
+ Coverage   90.25%   91.15%   +0.90%     
==========================================
  Files         354      354              
  Lines       46057    46076      +19     
==========================================
+ Hits        41567    42002     +435     
+ Misses       4490     4074     -416     
Impacted Files Coverage Δ
datalad/tests/test_misc.py 100.00% <ø> (+15.00%) ⬆️
datalad/runner/tests/test_threadsafety.py 70.65% <0.00%> (-29.35%) ⬇️
datalad/tests/utils.py 66.76% <0.00%> (+9.55%) ⬆️
datalad/tests/test_tests_utils.py 92.34% <0.00%> (+92.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dea515...6e56d75. Read the comment docs.

@yarikoptic

Copy link
Copy Markdown
Member Author

Fail is test_ssh_copy

@yarikoptic yarikoptic merged commit 2235ec8 into datalad:maint Jul 9, 2022
@yarikoptic yarikoptic deleted the rm-test-test branch July 11, 2022 19:54
@github-actions

Copy link
Copy Markdown
Contributor

🚀 PR was released in 0.17.1 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released semver-tests Changes only affect tests, no impact on version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant