Do not quote paths for ssh >= 9 #6826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a very rough ssh-version detection to deal with different filename quoting requirements in ssh version <= 8 and in ssh version 9. This fixes the ssh copy tests error that is described in issue datalad#6806. This is a rough first draft to verify the overall viability and to test the waters in CI. The version parsing will have to be improved.
This commit adds a "# nosec" comment to an application of 'md5' in order to skip insecure-hash checks by 'codeclimate'. The hash is not security critical, since it is only used as an "abbreviation" of the unique connection property string.
This commit adds '<' and '>' to the characters that can be put into an obscure filename.
Thie commit adds a regular expression to determine the version, sub-version and patch-number of the used ssh-client. It currently only recognizes "OpenSSH" versions.
This commit removes the custom ssh-version detection code from sshconnector.py in favor of the existing version detection code in external_versions.py
This commit refactors the external version detection for ssh to include the ssh type. Currently only OpenSSH is recognized, all other types are considered to be unknown.
This commit removes the ssh type signaling in the external versions object because it exhibited too many incompatibilities and we do not really have a strategy to deal with ssh types other than OpenSSH.
now we use external_versions to get version and it does not store implementation. So compare just against the [0]
Swapped the logic for version comparison so that if we have not figured out ssh version, we do not quote (since we do not know if we should).
This was referenced Jul 9, 2022
Codecov Report
@@ Coverage Diff @@
## maint #6826 +/- ##
==========================================
+ Coverage 90.24% 91.21% +0.96%
==========================================
Files 354 354
Lines 46056 46064 +8
==========================================
+ Hits 41563 42017 +454
+ Misses 4493 4047 -446
Continue to review full report at Codecov.
|
|
Oh you are so green, 💚 it |
|
@yarikoptic Thanks for fixing the last bugs. Niche surprise! Just sat down to fix and: voila, it's already done. Thx |
christian-monch
approved these changes
Jul 10, 2022
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the work by @christian-monch in #6812 with 2 little final tune ups to get it working and robustify against case where version is None for some reason (avoid quoting). And also submitted against
maint.I would appreciate quite review/merge since that test kept failing all our CI runs, bringing fatigue.