Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support older pytests #6836

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Support older pytests #6836

merged 1 commit into from
Jul 13, 2022

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jul 12, 2022

Fixes #6835.

Changelog

馃洝 Tests

  • Support older versions of pytest

@jwodder jwodder added the semver-tests Changes only affect tests, no impact on version label Jul 12, 2022
@yarikoptic
Copy link
Member

Thank you! I will test it within debian stable package build env and will report back.

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #6836 (4183eb1) into maint (9679312) will increase coverage by 0.97%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##            maint    #6836      +/-   ##
==========================================
+ Coverage   90.25%   91.23%   +0.97%     
==========================================
  Files         354      354              
  Lines       46064    46079      +15     
==========================================
+ Hits        41575    42039     +464     
+ Misses       4489     4040     -449     
Impacted Files Coverage 螖
datalad/conftest.py 90.74% <80.00%> (+1.02%) 猬嗭笍
datalad/customremotes/tests/test_datalad.py 95.34% <0.00%> (-2.28%) 猬囷笍
datalad/distribution/create_sibling.py 69.80% <0.00%> (-0.20%) 猬囷笍
datalad/cli/common_args.py 100.00% <0.00%> (酶)
datalad/tests/test_dochelpers.py 100.00% <0.00%> (酶)
datalad/support/tests/test_network.py 100.00% <0.00%> (酶)
datalad/tests/utils_pytest.py 89.73% <0.00%> (+0.01%) 猬嗭笍
datalad/utils.py 88.17% <0.00%> (+0.01%) 猬嗭笍
datalad/__init__.py 98.00% <0.00%> (+0.04%) 猬嗭笍
datalad/support/tests/test_locking.py 95.87% <0.00%> (+0.04%) 猬嗭笍
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 5a1c4bd...4183eb1. Read the comment docs.

@yarikoptic
Copy link
Member

FWIW, patching with the diff from this PR allowed debian package build -- will now do for a proper -2 debian pkg build. not sure why one CI run here https://github.com/datalad/datalad/runs/7304081650?check_suite_focus=true seems got stuck but should not relate IMHO.

Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is finally done and green. I will let others to provide feedback, and if no feedback - will merge tomorrow

@yarikoptic
Copy link
Member

worked out well, no objections, let's proceed

@github-actions
Copy link

馃殌 PR was released in 0.17.2 馃殌

@jwodder jwodder deleted the gh-6835 branch May 12, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released semver-tests Changes only affect tests, no impact on version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants