XFAIL test_runner_parametrized_protocol on python3.8 when getting duplicate output#6837
Merged
Merged
Conversation
…licate output This should close (unresolved) but not fix datalad#4921 which seems to happen so far rarely on conda on 3.8 python only. If some brave soul manages to figure it out -- great. But I would not break our knuckles to see it fixed since seems to be very particular. I made xfail also very particular (not over entire test, only for 3.8 and only for the 55 output) so we do not miss any other problem
yarikoptic
added
the
semver-tests
Codecov Report
@@ Coverage Diff @@
## maint #6837 +/- ##
==========================================
+ Coverage 90.25% 91.22% +0.96%
==========================================
Files 354 354
Lines 46064 46083 +19
==========================================
+ Hits 41575 42038 +463
+ Misses 4489 4045 -444
Continue to review full report at Codecov.
|
Member
Author
|
any objections/blessings @datalad/developers ? |
Member
Author
|
ok, no objections then. |
|
🚀 PR was released in |
yarikoptic
commented
Aug 24, 2022
| eq_(res['stdout'], '5') | ||
| except AssertionError: | ||
| # TODO: remove when dropping support for python3.8 | ||
| if res['stdout'] == '55' and sys.version_info[:2] == (3, 8): |
Member
Author
There was a problem hiding this comment.
apparently not 3.8 specific -- happened for 3.9 https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=556819&view=logs&j=517fe804-fa30-5dc2-1413-330699242c05&t=c10fa5f2-fdf6-5338-3bdb-c4bea7c23412
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should close (unresolved) but not fix #4921
which seems to happen so far rarely on conda on 3.8 python only. If some brave soul
manages to figure it out -- great. But I would not break our knuckles to see it fixed
since seems to be very particular. I made xfail also very particular (not over entire
test, only for 3.8 and only for the 55 output) so we do not miss any other problem